Add date format to exported logs #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make them same as in logs list
| @@ -21,6 +22,8 @@ internal class SentinelFileTree( | |||
| private val logFileResolver = LogFileResolver(context) | |||
|
|
|||
| override fun log(priority: Int, tag: String?, message: String, t: Throwable?) { | |||
| val dateTimeFormat = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss. SSSZ", Locale.getDefault()) | |||
There was a problem hiding this comment.
If I'm interpreting the screenshot correctly, this space seems unnecessary.
Suggested change
| val dateTimeFormat = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss. SSSZ", Locale.getDefault()) | |
| val dateTimeFormat = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ", Locale.getDefault()) |
|
|
||
| internal class LoggerAdapter( | ||
| private val onListChanged: (Boolean) -> Unit, | ||
| private val onClick: (SentinelFileTree.Entry) -> Unit | ||
| ) : ListAdapter<SentinelFileTree.Entry, LoggerViewHolder>(LoggerDiffUtil()) { | ||
|
|
||
| private val dateTimeFormat = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss. SSSZ", Locale.getDefault()) |
There was a problem hiding this comment.
Here too, and it also makes me wonder if we could just share this pattern or formatted between the two files 😄
Suggested change
| private val dateTimeFormat = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss. SSSZ", Locale.getDefault()) | |
| private val dateTimeFormat = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ", Locale.getDefault()) |
JonatanPlesko
approved these changes
Jul 8, 2024
…date-in-exported-logs
|
KCeh
deleted the
feature/Parse-UNIX-timestamp-to-readable-date-in-exported-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
📄 Context
As requested in #47 exported logs now have human-readable timestamp (same format as logcat). Also, to have the consistency I added same date-time format to the list of logs (and log files)
📝 Changes
Added date-time formating when writing logs to files. Changed date-time formatting in list of logs
🛠️ How to test
Try out sample app